Skip to content

Commit

Permalink
Build: Only install Playwright dependencies when needed
Browse files Browse the repository at this point in the history
PR jquerygh-5190 added support for running tests on Playwright WebKit
in CI. For efficiency reasons, Playwright dependencies are only
installed for the `test:browser` npm script. However, that same
script is also used for Firefox ESR testing.

This change makes Playwright dependencies installed only for cases
where `WebKitHeadless` exists on the list of tested browsers.

Closes jquerygh-5204
Ref jquerygh-5190
  • Loading branch information
mgol authored Mar 20, 2023
1 parent ce264e0 commit e77bd9d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
- name: Install Playwright dependencies
run: npx playwright-webkit install-deps
if: "matrix.NPM_SCRIPT == 'test:browser'"
if: "matrix.NPM_SCRIPT == 'test:browser' && contains(matrix.BROWSERS, 'WebkitHeadless')"

- name: Run tests
env:
Expand Down

0 comments on commit e77bd9d

Please sign in to comment.