Add block-network-request command #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a reasonable way to simulate a flakey network,
busted deploy, or ad blocker. It lets us actively block a
network request that the page makes.
// to simulate JS that is enabled, but fails to load
block-network-request: "*.js"
This is the simplest case, but is not the only useful one.
It can also block specific files, and it can stack:
block-network-request: "*/search-index.js"
block-network-request: "*/search.js"
Once a block list is added, there's no way to remove it.
Flakey network tests will probably be in separate test files,
so that shouldn't be a serious weakness.
| @@ -0,0 +1,13 @@ | |||
| // This test is meant to ensure that we can block an external script request. | |||
| // Since we are intentionally causing request errors, don't block them. | |||
| fail-on-request-error: false | |||
There was a problem hiding this comment.
Could you mention this in the documentation as well please? Could be surprising that a test fails if you block a request in another command.
There was a problem hiding this comment.
Okay, I've addressed both nits.
GuillaumeGomez
approved these changes
Apr 4, 2024
|
Awesome, thanks! |
|
I'll make a new release soon and update rust-lang/rust#123407. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a reasonable way to simulate a flakey network, busted deploy, or ad blocker. It lets us actively block a network request that the page makes.
This is the simplest case, but is not the only useful one. It can also block specific files, and it can stack:
Once a block list is added, there's no way to remove it. Flakey network tests will probably be in separate test files, so that shouldn't be a serious weakness.
CC rust-lang/rust#123407