typehints #80
Merged
typehints #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2.x #80 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 2 2
Lines 341 341
Branches 17 17
=======================================
Hits 330 330
Misses 6 6
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
leoguignard
requested changes
Jun 30, 2025
| @@ -68,7 +68,7 @@ def __len__(self): | |||
| def __iter__(self): | |||
Member
There was a problem hiding this comment.
Maybe you could put a type hint here too?
Contributor
|
@BadPrograms L2671, Otherwise it all looks good to me 👍 |
leoguignard
requested changes
Jun 30, 2025
| yield from self.lineagetrees.items() | ||
|
|
||
| def __getitem__(self, key): | ||
| def __getitem__(self, key) -> lineageTree: |
Member
There was a problem hiding this comment.
Please type hing on the arguments too
ChrisMzz
approved these changes
Jun 30, 2025
leoguignard
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.