-
Notifications
You must be signed in to change notification settings - Fork 7
feat: migrate deployment and previews on Github Pages #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eebc2f3 to
98c7966
Compare
98c7966 to
373b042
Compare
|
d5b5f8f to
736cd7a
Compare
fc08017 to
c300484
Compare
| paths: | ||
| - "blog/**" | ||
| - ".github/workflows/blog.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should include also the .moon/toolchain.yml and .moon/workspace.yml as well
In this case:
If we bump golang version in the tool chain or moon related stuff, it should re-deploy the blog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only added the .moon/toolchains.yml file. I don't see any value to add .moon/workspace.yml for now as it is only for repository configuration
| paths: | ||
| - "app/**" | ||
| - ".github/workflows/app-deploy-live.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should include also the .moon/toolchain.yml and .moon/workspace.yml as well
In this case:
If we bump node.js version in the tool chain or moon related stuff, it should re-deploy the application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've only added the .moon/toolchains.yml file. I don't see any value to add .moon/workspace.yml for now as it is only for repository configuration
6872808 to
8282079
Compare
8282079 to
9889c15
Compare
9889c15 to
6115f51
Compare
|
@Gudsfile Can you remove unused secrets from Repository Settings as we're now on Github Pages? |
Done 🎉 |
1️⃣ First
🔇 Problem
The project was using Firebase Hosting for deployment, which required secrets and external infrastructure. Additionally, the blog was deployed separately on Github Pages, creating fragmentation in the deployment process.
🎹 Proposal
Complete migration to GitHub Pages for deployment:
Commit 1: Deploy blog on Github Pages (5cfb4b4)
Commit 2: Deploy app on Github Pages (58a4542)
base: '/tracksy'andsite: 'https://gudsfile.github.io'Commit 3: Deploy PR preview on Github Pages (736cd7a)
process.env.BASE_PATH || '/tracksy'in astro.config.mjs/tracksy/pr-preview/pr-XXX/)🎶 Comments
This migration brings several benefits:
🎤 Test
Tested Configuration
https://gudsfile.github.io/tracksy/blog/https://gudsfile.github.io/tracksy/with correct base pathhttps://gudsfile.github.io/tracksy/pr-preview/pr-XXX/with resources loading correctlyVerifications
Additional Steps
Closes #221