Close bmlab session after loading data #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
What happens if multiple bmlab files are opened? Is everything always copied into memory? |
raimund-schluessler
force-pushed
the
fix/noid/close-bmlab-files
branch
from
a75c959 to
f4dd3fc
Compare
Contributor
Author
Currently, if multiple bmlab files are opened, multiple sessions are created and all loaded files are still locked after the data was loaded.
Yes, in this regard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the files loaded by bmlab are locked until Impose is quit. Since we only need them once to load the data, this PR fixes this.