V1.26.0

.github/repository-settings.md

@@ -6,7 +6,7 @@ settings](https://github.com/open-telemetry/community/blob/main/docs/how-to-conf
 
 ## General > Pull Requests
 
-* Allow squash merging > Default to pull request title and description
+* Allow squash merging > Default to pull request title
 
 * Allow auto-merge
 

.github/scripts/markdown-link-check-config.json

@@ -1,15 +1,18 @@
 {
-  "retryOn429" : true,
-  "aliveStatusCodes" : [
+  "retryOn429": true,
+  "aliveStatusCodes": [
     200,
     403
   ],
-  "ignorePatterns" : [
+  "ignorePatterns": [
     {
-      "pattern" : "https://github.com/open-telemetry/opentelemetry-java-instrumentation/network/updates"
+      "pattern": "https://github.com/open-telemetry/opentelemetry-java-instrumentation/network/updates"
     },
     {
-      "pattern" : "^https://kotlinlang\\.org/docs/coroutines-overview\\.html$"
+      "pattern": "^https://github.com/open-telemetry/opentelemetry-java-contrib/pulls/app%2Fdependabot$"
+    },
+    {
+      "pattern": "^https://kotlinlang\\.org/docs/coroutines-overview\\.html$"
     }
   ]
 }

.github/workflows/auto-update-otel-sdk.yml

@@ -57,15 +57,20 @@ jobs:
           VERSION: ${{ needs.check-versions.outputs.latest-version }}
         run: ./.github/scripts/update-sdk-version.sh $VERSION
 
+      - name: Use CLA approved github bot
+        run: .github/scripts/use-cla-approved-github-bot.sh
+
       - name: Update license report
         uses: gradle/gradle-build-action@v2
         with:
           arguments: generateLicenseReport
 
-      - name: Use CLA approved github bot
-        run: .github/scripts/use-cla-approved-github-bot.sh
+      - name: Undo license report clean
+        if: failure()
+        run: git checkout -- licenses
 
       - name: Create pull request against main
+        if: success() || failure()
         env:
           VERSION: ${{ needs.check-versions.outputs.latest-version }}
           # not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows

.github/workflows/build-common.yml

@@ -96,7 +96,7 @@ jobs:
             exit 1
           fi
 
-  assemble:
+  build:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
@@ -107,15 +107,19 @@ jobs:
           distribution: temurin
           java-version: 17
 
-      - name: Assemble
+      - name: Increase gradle daemon heap size
+        run: |
+          sed -i "s/org.gradle.jvmargs=/org.gradle.jvmargs=-Xmx3g /" gradle.properties
+
+      - name: Build
         uses: gradle/gradle-build-action@v2
         env:
           GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
           GE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
           GE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
         with:
           # javadoc task fails sporadically fetching https://docs.oracle.com/javase/8/docs/api/
-          arguments: assemble -x javadoc ${{ inputs.no-build-cache && '--no-build-cache' || '' }}
+          arguments: check -x javadoc -x spotlessCheck -PskipTests=true ${{ inputs.no-build-cache && '--no-build-cache' || '' }}
           cache-read-only: ${{ inputs.cache-read-only }}
           # gradle enterprise is used for the build cache
           gradle-home-cache-excludes: caches/build-cache-1
@@ -143,7 +147,7 @@ jobs:
           - 8
           - 11
           - 17
-          - 19
+          - 20
         vm:
           - hotspot
           - openj9
@@ -154,7 +158,7 @@ jobs:
           - 3
         exclude:
           - vm: ${{ inputs.skip-openj9-tests && 'openj9' || '' }}
-          - test-java-version: 19
+          - test-java-version: 20
             vm: openj9
       fail-fast: false
     steps:
@@ -194,6 +198,26 @@ jobs:
       - name: Start deadlock detector
         run: .github/scripts/deadlock-detector.sh
 
+      - name: List tests
+        env:
+          GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
+          GE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+          GE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+        uses: gradle/gradle-build-action@v2
+        with:
+          # "check" is needed to activate all tests for listing purposes
+          # listTestsInPartition writes test tasks that apply to the given partition to a file named
+          # "test-tasks.txt" and then disables all tasks (including tests) after it runs
+          arguments: >
+            check -x spotlessCheck
+            listTestsInPartition
+            -PtestPartition=${{ matrix.test-partition }}
+          cache-read-only: true
+
+      - name: Set test tasks
+        run: |
+          echo "test-tasks=$(cat test-tasks.txt | xargs echo | sed 's/\n/ /g')" >> $GITHUB_ENV
+
       - name: Test
         env:
           GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GRADLE_ENTERPRISE_ACCESS_KEY }}
@@ -203,13 +227,11 @@ jobs:
         with:
           # spotless is checked separately since it's a common source of failure
           arguments: >
-            check
-            -x spotlessCheck
+            ${{ env.test-tasks }}
             -PtestJavaVersion=${{ matrix.test-java-version }}
             -PtestJavaVM=${{ matrix.vm }}
             -Porg.gradle.java.installations.paths=${{ steps.setup-test-java.outputs.path }}
             -Porg.gradle.java.installations.auto-download=false
-            -PtestPartition=${{ matrix.test-partition }}
             ${{ inputs.no-build-cache && ' --no-build-cache' || '' }}
           # only push cache for one matrix option since github action cache space is limited
           cache-read-only: ${{ inputs.cache-read-only || matrix.test-java-version != 11 || matrix.vm != 'hotspot' }}
@@ -220,15 +242,15 @@ jobs:
         if: failure()
         uses: actions/upload-artifact@v3
         with:
-          name: deadlock-detector-test-${{ matrix.test-java-version }}-${{ matrix.vm }}
+          name: deadlock-detector-test-${{ matrix.test-java-version }}-${{ matrix.vm }}-${{ matrix.test-partition }}
           path: /tmp/deadlock-detector-*
           if-no-files-found: ignore
 
       - name: Upload jvm crash dump files if any
         if: failure()
         uses: actions/upload-artifact@v3
         with:
-          name: javacore-test-${{ matrix.test-java-version }}
+          name: javacore-test-${{ matrix.test-java-version }}-${{ matrix.test-partition }}
           path: |
             **/hs_err_pid*.log
             **/javacore.*.txt

.github/workflows/build-daily-no-build-cache.yml

@@ -27,9 +27,15 @@ jobs:
   # markdown-link-check and misspell-check are not included here because they don't use gradle cache
   # anyway and so are already covered by the normal daily build
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - common
       - test-latest-deps
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: |
+        ${{
+          needs.common.result == 'success' &&
+          needs.test-latest-deps.result == 'success'
+        }}

.github/workflows/build-daily.yml

@@ -36,12 +36,21 @@ jobs:
   misspell-check:
     uses: ./.github/workflows/reusable-misspell-check.yml
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - common
       - test-latest-deps
       - muzzle
       - markdown-link-check
       - misspell-check
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: |
+        ${{
+          needs.common.result == 'success' &&
+          needs.test-latest-deps.result == 'success' &&
+          needs.muzzle.result == 'success' &&
+          needs.markdown-link-check.result == 'success' &&
+          needs.misspell-check.result == 'success'
+        }}

.github/workflows/codeql-daily.yml

@@ -35,9 +35,10 @@ jobs:
       - name: Perform CodeQL analysis
         uses: github/codeql-action/analyze@v2
 
-  open-issue-on-failure:
-    # open an issue on failure because it can be easy to miss CI failure notifications
+  workflow-notification:
     needs:
       - analyze
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: ${{ needs.analyze.result == 'success' }}

.github/workflows/overhead-benchmark-daily.yml

@@ -45,8 +45,10 @@ jobs:
           committer_name: opentelemetrybot
           committer_email: 107717825+opentelemetrybot@users.noreply.github.com
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - run-overhead-tests
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: ${{ needs.run-overhead-tests.result == 'success' }}

.github/workflows/publish-smoke-test-fake-backend-images.yml

@@ -68,9 +68,16 @@ jobs:
         with:
           arguments: ":smoke-tests:images:fake-backend:dockerPush -PextraTag=${{ env.TAG }}"
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - publishLinux
       - publishWindows
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: |
+        ${{
+          needs.publishLinux.result == 'success' &&
+          needs.publishWindows.result == 'success'
+        }}
+

.github/workflows/publish-smoke-test-grpc-images.yml

@@ -16,8 +16,10 @@ jobs:
       project: ":smoke-tests:images:grpc"
       publish: true
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - publish
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: ${{ needs.publish.result == 'success' }}

.github/workflows/publish-smoke-test-play-images.yml

@@ -20,8 +20,10 @@ jobs:
       skip-java-17: true
       skip-java-19: true
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - publish
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: ${{ needs.publish.result == 'success' }}

.github/workflows/publish-smoke-test-quarkus-images.yml

@@ -18,8 +18,10 @@ jobs:
       # Quarkus 2.0+ does not support Java 8
       skip-java-8: true
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - publish
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: ${{ needs.publish.result == 'success' }}

.github/workflows/publish-smoke-test-security-manager-images.yml

@@ -16,8 +16,10 @@ jobs:
       project: ":smoke-tests:images:security-manager"
       publish: true
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - publish
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: ${{ needs.publish.result == 'success' }}

.github/workflows/publish-smoke-test-servlet-images.yml

@@ -76,8 +76,10 @@ jobs:
         if: matrix.os == 'windows-latest'
         run: ./gradlew :smoke-tests:images:servlet:buildWindowsTestImages pushMatrix -PextraTag=${{ needs.prepare.outputs.tag }} -PsmokeTestServer=${{ matrix.smoke-test-server }}
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - publish
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: ${{ needs.publish.result == 'success' }}

.github/workflows/publish-smoke-test-spring-boot-images.yml

@@ -16,8 +16,10 @@ jobs:
       project: ":smoke-tests:images:spring-boot"
       publish: true
 
-  open-issue-on-failure:
+  workflow-notification:
     needs:
       - publish
-    if: failure() && github.run_attempt == 1
-    uses: ./.github/workflows/reusable-open-issue-on-failure.yml
+    if: always()
+    uses: ./.github/workflows/reusable-workflow-notification.yml
+    with:
+      success: ${{ needs.publish.result == 'success' }}

.github/workflows/release.yml

@@ -227,11 +227,3 @@ jobs:
       version: ${{ needs.release.outputs.version }}
     secrets:
       OPENTELEMETRYBOT_GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
-
-  create-website-pull-request:
-    needs: release
-    uses: ./.github/workflows/reusable-create-website-pull-request.yml
-    with:
-      version: ${{ needs.release.outputs.version }}
-    secrets:
-      OPENTELEMETRYBOT_GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}