Add a description - #2342
Open
sryazantsev wants to merge 8 commits into
Open
Conversation
added 8 commits
August 9, 2026 14:13
Install the Guake tray icon into standard icon locations and refresh the hicolor icon cache during installation. Complete Ukrainian translations for preferences, menus, command-line help, Quick Open, session handling, and runtime messages.
- add a language selector to the Appearance preferences and persist it in GSettings - apply the saved language before gettext initialization, with LANGUAGE and system locale fallback - fix hotkey preferences GTK renderer duplication and accelerator model types - remove ignored VTE spawn flags that produced runtime warnings - insert tab-context new tabs after the current tab while keeping the toolbar button at the end - use a legacy tray icon on Cinnamon so left-click toggles Guake visibility - execute Quick Open commands without shell=True and add focused tests
- add persistent language selection with saved preference precedence and document the restart requirement\n- implement debounced tab-session saving and asynchronous VTE terminal spawning\n- handle missing asynchronous PIDs safely and avoid invalid VTE destruction during tab restore\n- preserve tab placement, fullscreen tab-bar visibility, tray toggling, and context-menu tab insertion behavior\n- harden Quick Open command construction and retain focused coverage\n- update Ukrainian and regenerated translation catalogs, dependency locks, build requirements, and contributor guidance in AGENTS.md\n\nValidation: 35 GUI tests passed with 5 deprecation warnings; total coverage 45%; flake8, pylint, compileall, and git diff --check passed.\nKnown environment limitation: cached pre-commit flake8/pylint hooks are incompatible with Python 3.12; make build currently fails in the cached setuptools_scm sdist dependency because vcs_versioning is unavailable.
Make session persistence atomic and keep autosave enabled when malformed workspace data is encountered. Handle GSettings schema refresh failures gracefully when the installed schema directory is not writable, and correct package data path detection for site-packages and dist-packages. Rework make install to respect PREFIX and DESTDIR for both /usr and /usr/local, install the Python package without global dependency resolution, and keep setuptools/setuptools_scm versions compatible with the legacy build configuration. Add the PEP 517 build requirements and lockfile pins. Document the updated installation and runtime behavior and add regression coverage for restoring autosave after an invalid session.
Preserve the original LANGUAGE value for child shells while using the saved preference for Guake. Make reinstall synchronize the user schema version, require GTK 3 Gdk explicitly, and add regression tests for terminal environments.
Run the complete test suite explicitly from Makefile targets and add regression coverage for sessions, workspaces, Quick Open, terminal lifecycle, split geometry, tab naming, and autosave behavior.
Validate session schema input, preserve active workspace selection, avoid unwritable GSettings schema refreshes, and handle Quick Open spawn failures safely. Extend regression coverage for startup, sessions, paths, terminals, notebooks, and utility decorators.
Upgrade the flake8 and pylint hooks to the versions already pinned in the project environment. This restores pre-commit validation on Python 3.12 without skipping either linter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request contains four commits that improve Guake runtime behavior, terminal lifecycle management, translations, session persistence, and source installation.
Changes
os.replace.site-packagesanddist-packages.make installcorrectly respectPREFIXandDESTDIR./usrand/usr/local.Validation
/usrwas verified./usr/localwas verified.guake --versionstarts successfully.