Text search in the current terminal

[kikecalpe]

Want to be able to make text search in the terminal http://guake.org/ticket/362
Reported by: sylock Owned by: somebody
Priority: minor Milestone: 0.5.0
Component: guake Version:
Keywords: Cc:
Description

It would be great being able to make search on the output of the shells. For exemple, with a shorcut CTRL-f. And n for next match (and N for previous match). Being able to use regex in the search would be great either.

[gsemet]

I really like this feature!

[gsemet]

Should not be difficult: Provided by https://developer.gnome.org/vte/unstable/VteTerminal.html#vte-terminal-search-set-gregex

TODO:

• display a "firefox"/"chrome" search panel on Ctrl+F (or Ctrl+Shift+F)
• search next (on "Enter") / previous (On "Ctrl + Enter")
• support regex

[Ginja]

+1

[alex-kirienko]

Can you implement this feature ? Please

[gsemet]

I really would like but I have not time to work on guake for the moment

[rbu]

Oh I would love this. It's a shame guake is missing this feature in comparison to the regular gnome terminal or something like yakuake.

[ckorobov]

+1

[gsemet]

Sadly, the python-vte module doesn't export the search methods. This means there is quite a big change to do on the binary itself, and then upload to maintainers and distributions (ubuntu, ...) and then, only then, have access to these methods... I'll try another way...

[toritsejuFO]

This feature hasn't been implemented yet? I just tried searching with the intuitive command (Ctrl+f and Ctrl+shift+f) but it didn't work. And I can't find any command that does so in preferences.

[daroczig]

I ended up using tmux in Guage for this purpose.

[toritsejuFO]

Oh yeah ;). I only like using tmux on remote servers though, and not locally because of the hassle of scrolling. Thanks for replying anyways.

[der-ali]

+1

[TookTheRedBean]

+1

[Nikitenko]

I believe and hope.

[gsemet]

Hi guys :) just had a baby girl, so maintaining guake is now low priority, but i’ll try to continue on it when possible, at least to release a new version with recent change. Text search is not hard, just need some time...

[toritsejuFO]

Congratulations! :)

[howyay]

Congrats :D

[preactive]

Congratulations on the baby girl @gsemet!

[gsemet]

and if one of you want to have a look at the code, do not hesitate ! Pull Requests are very much loved here :)

[derrix060]

@gsemet I'm very keen to implement it, but I have no idea for what to start.. Can you provide some high-level steps of what needs to be done to support it?

[gsemet]

Hi. a glade file has been started some months ago, not sure how to deal with it.

• having a dialog box sucks. Not really usable, except done carefully
• I like how iterm2 on mac does that:
  • a small text search appear on the screen (a-la firefox), and by default you actually search backward which is exactly was we want to do most of the time
  • you can still search forward
  • text are automatically selected so it is visually compeling

Appart by installing the dev environment (see the documentation), and hacking the python code, I can't say more on that. Once you have started hacking and see how it works, it is not really difficult. Time consuming yes. Difficult no :) Good luck

[frederickjh]

Tilda another dropdown terminal has had this feature since Nov 17, 2015. Switching to Tilda was my solution for searching in a dropdown terminal. On Ubuntu you can install with sudo apt install tilda.

[gsemet]

Done in #1533

[chax]

Hi, i just tested this new feature and i must say search box doesn't look good with dark theme because overlay background is light-colored and dark themes usually have light-colored fonts, so it's barely visible and it's very hard to read what you type. At first i thought it's not working because i couldn't see the text at all until i really focused my eyes on the search box. Also, background is not transparent as the rest of the terminal, so it looks really ugly and it really stands out from the rest of design. At least make background the right color (the one provided by the current selected GTK theme).

[gsemet]

Hi. Can you open a new ticket for this request please? Le ven. 26 avr. 2019 à 11:47, Mislav Čakarić <notifications@github.com> a écrit :

Hi, i just tested this new feature and i must say search box doesn't look good with dark theme because overlay background is light-colored and dark themes usually have light-colored fonts, so it's barely visible and it's very hard to read what you type. At first i thought it's not working because i couldn't see the text at all until i really focused my eyes on the search box. Also, background is not transparent as the rest of the terminal, so it looks really ugly and it really stands out from the rest of design. At least make background the right color (the one provided by the current selected GTK theme). — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#116 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABAS6UST6FUIZ2Y2QFCORTPSLFRLANCNFSM4AE6IJBQ> .

-- ----- Gaetan

[chax]

yep, will do

[chax]

@gsemet Here it is: #1561

[pevogam]

Is there any issue being reported where the search box looks good already but doesn't do anything upon Enter or Previous/Next arrow click?

[Davidy22]

I'm testing this and not seeing this happen, which version of guake are you on?

[pevogam]

The environment I have is

$ guake --version
Guake Terminal: 3.7.0
VTE: 0.68.0
VTE runtime: 0.68.0
Gtk: 3.24.34

and identical problems have been reported with environments in #1533 (comment).

[Davidy22]

3.7 is several versions behind current, as is the 3.6.x version reported in the linked issue. The search box has received changes most recently in 3.8 that likely fix issues with it.

[pevogam]

For various reason I have to wait for my Fedora release to catch up to that. I am still not convinced it is fixed there but will be forced to wait for later. Thanks for the feedback though.