[BUGFIX] Fix wrong URL resolution at octokit/grapql queries in Github Enterprise #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! |
gilbertsoft
added a commit
that referenced
this pull request
Mar 6, 2022
… Enterprise (#54) * [BUGFIX] Fix wrong URL resolution at octokit/grapql queries in G.Enterprise * [TASK] Ignore IDE related files & folders Co-authored-by: Simon Gilli <25326036+gilbertsoft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octokit/grapql queries points to wrong Github Urls. When I look into details, I have seen that it is using
https://api.github.comby default. Made a small change that if there is a Github API URL definition it will use it.This GITHUB_API_URL comes with Github's own implementation, does not require a manual defined environment variable by the user.
Note: tried latest version of Octokit, it still has the same problem.