[Refactoring] Replace .count and .length with .size for collections #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved program efficiency (in querying in particular) by replacing .count and .length with .size for collections. Fix error in refactoring Reverted some .size into .count
|
Thanks! The code changes look fine, but you've broken a test, which you can run with the command Please fix it, and add yourself to CONTRIBUTORS.md. |
|
@pozorvlak I finished fixing the test. :) I added myself in the contributors list in another merge pull request that you've checked. #753 |
pozorvlak
added a commit
that referenced
this pull request
Jul 2, 2015
[Refactoring] Replace .count and .length with .size for collections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved program efficiency (in querying in particular) by replacing .count and .length with .size for collections as specified by @Skud in #566