Added search form on the places index page. #751
Conversation
|
Looks good! However, it should be covered by a test. I would say "just copy the existing test for the Show page", but
So you'd need to write a whole new file of "feature" tests for the places-index page. Do you feel confident to do that? The good news is that feature tests are more straightforward to write - that's why we deprecated view and controller tests! |
|
Thanks @pozorvlak! I'll start working on this as soon as I'm confident about testing. I'm at bit new to rails and I'm excited to try this one. GabrielSandoval, |
GabrielSandoval
force-pushed
the
search_form
branch
from
f31b23d to
87f1c6c
Compare
|
Hi @pozorvlak, I added the feature test for the places search form. Please see if it's all good. Thanks! |
| @@ -15,3 +15,16 @@ | |||
| Geocoder.configure(:lookup => :nominatim) | |||
| end | |||
|
|
|||
| Geocoder::Lookup::Test.add_stub( | |||
There was a problem hiding this comment.
Could you please move this to config/environments/test.rb along with the other Geocoder stubs?
There was a problem hiding this comment.
Hi, I moved the stubs to config/environments/test.rb. Just tell me if there's anything more needed to be done.
|
Excellent - thanks! |
Added search form on the places index page.
|
Thanks @pozorvlak! |
places#show has a search form but places#index doesn't have. I added a search form in the index page of the 'places' so that the users may easily search the place they want to see.
@pozorvlak Sorry I messed up my last PR. Here is a new one. I left the gitignore untouched this time.