#558 Currency refactoring in specs. #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -405,7 +405,6 @@ | |||
| t.datetime "updated_at" | |||
| t.string "slug" | |||
| t.integer "forum_id" | |||
| t.integer "parent_id" | |||
There was a problem hiding this comment.
This change looks like it shouldn't be here - can you remove it?
|
Looks good to merge once you've removed the stray change to |
andrba
force-pushed
the
currency_spec_refactoring
branch
from
cc6ade3 to
44b260b
Compare
|
@pozorvlak could you review it again? I removed the schema change |
pozorvlak
added a commit
that referenced
this pull request
Jun 26, 2015
#558 Currency refactoring in specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #558
I noticed that the application_helper.rb spec file wasn't following the naming conventions. I had to rename it.