Feature/robots dissalow on staging #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 4, 2015 23:11
New route to /robots.txt and some specific logic to switch on if the subdomain is staging or not. Staging will not allow any crawlers at all, production does not have any current limitations
Also assert that the response is the actual file contents instead of mocking the method call
yez
force-pushed
the
feature/robots-dissalow-on-staging
branch
from
7ebaa6a to
c1ab161
Compare
|
This looks good to me. Note: even though we are generally deprecating controller specs, this use seems appropriate. |
Skud
added a commit
that referenced
this pull request
May 19, 2015
Feature/robots dissalow on staging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #634
A per-subdomain robots.txt pattern has been introduced. The default is to load the production robots.txt file (currently empty with no guidelines for search engines). Staging version of the robots.txt file prevents all scraping from robots on entire site.