#621 Crop varieties sidebar #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| visit crop_path(crop) | ||
|
|
||
| # It lists all 5 items (note: including the top level item.) | ||
| # It DOES NOT have "Show all/less" toggle link |
There was a problem hiding this comment.
You might use a within block to focus on that .crop-hierarchy class.
There was a problem hiding this comment.
Good suggestion, thanks! Done now.
oshiho3
force-pushed
the
621-crop-varieties-sidebar
branch
from
b29a9f5 to
c253c86
Compare
1 similar comment
|
Code has been updated to incorporate @tygriffin's review and also
Apologize for modifying some stuff after the review. Can you please review this again? |
|
Looks good to me - moving into release 9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review.
Implemented #621 with javascript as I didn't realize rails-y implementation was preferred over javascript here and I wanted the toggle to look smooth instead of refreshing the whole page.
Let me know if you want me to rewrite using different technology etc.
Thanks!