Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to new secrets format #710

Merged
merged 3 commits into from
May 20, 2015
Merged

Switching to new secrets format #710

merged 3 commits into from
May 20, 2015

Conversation

cesy
Copy link
Member

@cesy cesy commented Feb 16, 2015

I found that rake was failing in my dev environment. The cause seems to be http://guides.rubyonrails.org/upgrading_ruby_on_rails.html#config-secrets-yml

Is this an issue for anyone else?

# run 'rake secret' to generate your own

production:
secret_key_base: <%= ENV["SECRET_KEY_BASE"] %>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll fix the missing line break shortly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this set? How is it pushed to Heroku? Please check application.yml (or the example one that's in github, anyway) and modify if necessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I meant to have it with the same name as the old one, so it would be no change in production/Heroku. Will fix.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.39% when pulling eb76db9 on cesy:secrets into 28288c5 on Growstuff:dev.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.39% when pulling 9b195d1 on cesy:secrets into 28288c5 on Growstuff:dev.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.37%) to 83.76% when pulling 2740b5e on cesy:secrets into 28288c5 on Growstuff:dev.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.37%) to 83.76% when pulling 2740b5e on cesy:secrets into 28288c5 on Growstuff:dev.

Skud added a commit that referenced this pull request May 20, 2015
Switching to new secrets format
@Skud Skud merged commit add275e into Growstuff:dev May 20, 2015
@cesy cesy deleted the secrets branch August 20, 2015 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants