Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation notice to all controller and view specs #706

Merged
merged 1 commit into from
May 20, 2015

Conversation

tygriffin
Copy link
Contributor

Fixes #622

Additionally, we can put all controller and view specs under a "deprecated" directory, so it's extra obvious. The paths would look like this: spec/views/deprecated/. Probably not necessary though.

@pozorvlak
Copy link
Member

pozorvlak commented Feb 13, 2015 via email

@tygriffin
Copy link
Contributor Author

@pozorvlak : Yeah, that would make the most sense. However, RSpec won't recognise those specs as view specs (therefore, you wouldn't have access to controller stubs, etc) and they'll all start failing.

@tygriffin tygriffin changed the title add deprecation not to all controller and view specs add deprecation notice to all controller and view specs Feb 14, 2015
@maco maco added this to the Release 9 milestone Apr 7, 2015
Skud added a commit that referenced this pull request May 20, 2015
add deprecation notice to all controller and view specs
@Skud Skud merged commit f830ed1 into Growstuff:dev May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add deprecation notes to top of all controller and view tests
4 participants