Api gets stuck at cp.catchPokemon(pokeball)

[jsl303]

The latest commit sometimes gets stuck at cp.catchPokemon(pokeball).
Can't seem to track down the cause. it just hangs at catchPokemon(pokeball) function.
I went back to previous commit dad8a4a, and it doesn't have the problem.

[Grover-c13]

on the very very latest commits? #404 #405

[jsl303]

Thanks! You guys are so fast! Love it. I see there are more commits.

I just pulled down commit 82fefdb.
Testing now. I'll report back.

On 7/31/2016 1:37 PM, Grover-c13 wrote:

on the very very latest commits? #404
#404 #405
#405

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#406 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALDSxzmHFAC2x9WS-JgVczHGaK4z968Pks5qbN1ngaJpZM4JZFGg.

[a4andy]

Also having the same issue with latest commit 82fefdb

[jsl303]

I'm on commit 82fefdb.

This one seems to get stuck less, but still get stuck on once in a while.

result = cp.catchPokemon(pokeball);

On 7/31/2016 4:23 PM, a4andy wrote:

Also having the same issue with latest commit 82fefdb
82fefdb

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#406 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALDSx4uVII0X6-TQSGwFkQTIss1DYqqAks5qbQQogaJpZM4JZFGg.

[jsl303]

I have been testing it for a while, and it definitely gets stuck at cp.catchPokemon(pokeball);.
Not all the time, but once in a while.
Also, after you catch all the pokemons in catchablePokemon, and refresh the following in the same spot,
catchablePokemon = map.getCatchablePokemon();
size = catchablePokemon.size();
It sometimes returns 1, and when you try to catch, nothing's there.
It happens enough that I think something weird is happening in the queue.
Also, the cpu usage is pretty high. None of these issues happen in the previous commits before sync future. I went back and check.
Could you investigate what might cause these after  the commit dad8a4a?
Thank you as always!

[jsl303]

I just pulled commit 4f85be1.
This one sometimes goes into infinite loop where catchablePokemon.size() is always 1, and there's nothing to encounter.

[jsl303]

Apparently pokemon that you already caught still remains in go.getMap().getCatchablePokemon().
Then the cp.encounterPokemon().getStatus() returns ENCOUNTER_ALREADY_HAPPENED.
Is there way to remove caught pokemons from the getCatchablePokemon()?
Or, should I keep refreshing getCatchablePokemon() and ignore ENCOUNTER_ALREADY_HAPPENED?

[Grover-c13]

Weird, thought i had fixed that issue

[Grover-c13]

are you 100% sure you have pulled?

[jsl303]

I'm pretty sure. I just ran git-rev-parse, and it says I'm on 4f85be1.

[jsl303]

Here's my code and result in case I missed something.
while (true) {
List catchablePokemon = go.getMap().getCatchablePokemon();
size = catchablePokemon.size();
System.out.println("Catching " + size + " Pokemons");
for (CatchablePokemon cp : catchablePokemon) {
EncounterResult encResult = cp.encounterPokemon();
System.out.println(encResult.getStatus());
if (!encResult.wasSuccessful()) continue;
PokemonId id = cp.getPokemonId();
System.out.println("Encountered:" + id);
CatchResult result = cp.catchPokemon();
String status= result.getStatus().name();
System.out.println("Attempt to catch: " + id + " " + status);
}
}
Catching 1 Pokemons
ENCOUNTER_SUCCESS
Encountered:PIDGEY
ASYNC CATCH CALL
ASYNC CATCH CALL
Attempt to catch: PIDGEY CATCH_SUCCESS
Catching 1 Pokemons
ENCOUNTER_ALREADY_HAPPENED
Catching 1 Pokemons
ENCOUNTER_ALREADY_HAPPENED
Catching 1 Pokemons
ENCOUNTER_ALREADY_HAPPENED
...........

[jsl303]

Commit cca2a1c still has this problem.

[FabianTerhorst]

Why it should"t?

[jsl303]

After catching all the pokemons in catchablePokemon, shouldn't go.getMap().getCatchablePokemon().size() report 0 unless there's new pokemon?

[Grover-c13]

yes it should, unless the cache timer had expired between the catch and the getCatchablePokemon