Extra maps #15
Open
Extra maps #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hmm, could this be used to make mixin configs too? |
PaintNinja
requested changes
Jun 7, 2023
Member
PaintNinja
left a comment
PaintNinja
left a comment
There was a problem hiding this comment.
I'm not a fan of putting unrelated file stuff inside the same DSL. mods.groovy isn't really intended for this.
If you really want to go down this route, I also think you should make it a bit smarter than just a plain Groovy version of the existing json/toml. For example, the Mixin compatibilityLevel should be inferred based on the MC version range in the deps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements extra maps, which are used for additional files (like
pack.mcmetaand mixin json files)For now, only a
pack.mcmetaextra map is implemented, in the forge version.Note: this PR was practically not possible without the breaking changes to
AbstractConvertTask.