Develop into main #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
submit form required assignment of timezone. was resulting in an error without one. also changed to only display publication year in the slider.
testing 1
still have path printing, trying turning off crs conversion that is probably redundant
convert Path obj to str
not using Path for current dir
shp worked without Path, fixing png path and then can identify correct order for using Path module
may not work
might work
converted to windows or not windows
Added a warning and link to the current google docs
Some moderate changes to plotting method to allow multiple raster layers eventually and to add different outline colors based on shp source. Metadata to populate the popups is a relatively important next step.
Adding stored attribute for creator email
Minor beautification steps
Included GroMoPo form feedback of time & info with form submission email to admins Removed "Model Authors" attribute from HydroShare additional information since the info is duplicated with Authors attribute
Testing if string validation is preventing form submission
Converting form ModelCountry output from list to string
Troubleshooting
Changing ModelCountry to text input as a test
…dded via layers which is much cleaner.
Adding "GroMoPo Metadata for" to the beginning of all titles
Adding CSV as export type, expanding the number of fields in the export, not limiting number of characters for geojson and csv
Update map, change mandatory form fields
In submit_model, the form should submit data now. Edits mostly involved removing blank values and lists from data sent to HydroShare. Also including form feedback in submission email. Removed old comments Switched Model Country input back to multi-country list Various updates to code that pulls GroMoPo data out of HydroShare to create the index
Adding an error notification email
Apparently, the error trapping needed error trapping
Taking out email notifications & associated email contact information
|
@rreinecke I think everything needed is in here, so please review/approve |
|
@samzipper Awesome! @kbefus you need to approve please so that I can merge. |
samzipper
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the work of Kristen into main.