Skip to content

fix[cartesian]: Fix absolute field-access in while-conditionals #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2025
Merged

fix[cartesian]: Fix absolute field-access in while-conditionals #2357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41c5cf8
fix while conditional absolute index field
twicki Oct 31, 2025
fe96801
add test code
twicki Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/gt4py/cartesian/gtc/debug/debug_codegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,13 @@ def generate_ij_loop(
self.body.dedent()
self.body.dedent()

def visit_While(self, while_node: gtc_common.While, **_) -> None:
while_condition = self.visit(while_node.cond)
def visit_While(self, while_node: gtc_common.While, **kwargs) -> None:
while_condition = self.visit(while_node.cond, **kwargs)
while_code = f"while {while_condition}:"
self.body.append(while_code)
with self.body.indented():
for statement in while_node.body:
self.visit(statement)
self.visit(statement, **kwargs)

def visit_HorizontalExecution(
self, horizontal_execution: oir.HorizontalExecution, **kwargs
Expand Down
17 changes: 17 additions & 0 deletions tests/cartesian_tests/integration_tests/multi_feature_tests/test_code_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1291,6 +1291,23 @@ def test_lower_dim_field(
test_lower_dim_field(k_arr, out_arr)
assert (out_arr[:, :, :] == 42.42).all()

@gtscript.stencil(backend=backend)
def test_conditional_absolute(
in_field: Field[np.float64],
out_field: Field[np.float64],
) -> None:
with computation(PARALLEL), interval(...):
k_level = 0
while in_field.at(K=k_level) < 2:
k_level += 1
out_field[0, 0, 0] = k_level

in_arr[:, :, :] = 1
in_arr[:, :, 3] = 10
out_arr[:, :, :] = 0
test_conditional_absolute(in_arr, out_arr)
assert (out_arr[:, :, :] == 3).all()


@pytest.mark.parametrize(
"backend",
Expand Down