fix[next]: apply cse in fuse_as_fieldop #2257
Draft
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havogt
commented
Sep 11, 2025
| new_stencil, opcount_preserving=True, force_inline_lift_args=True | ||
| ) | ||
| new_stencil = inline_lifts.InlineLifts().visit(new_stencil) | ||
| new_stencil = cse.CommonSubexpressionElimination.apply( |
There was a problem hiding this comment.
try copying over the type of new_stencil
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies cse in fuse_as_fieldop to simplify the tree in nested repeated operations.
TODO:
Couldn't detect partial shift in any arguments of 'reduce'.. I have a fix for that problem, but not sure if later removal of map/make_const_list etc works.