refactor: introduce the ProjectInput structure#7908
refactor: introduce the ProjectInput structure#7908fengys1996 wants to merge 2 commits intoGreptimeTeam:mainfrom
Conversation
github-actions
bot
added
size/S
docs-not-required
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors ScanRequest by replacing the projection field with a ProjectionInput struct, enabling support for nested field access in complex columns. The changes are propagated through the system schema, metric engine, and mito2 engine. A review comment suggests removing a commented-out import in the metric engine to improve code quality.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2bc487592
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| write!(f, "ScanRequest {{ ")?; | ||
| if let Some(projection) = &self.projection { | ||
| if let Some(projection) = &self.projection_input { | ||
| write!(f, "{}projection: {:?}", delimiter.as_str(), projection)?; |
There was a problem hiding this comment.
ScanRequest now formats projection_input with {:?}, so logs/output become projection: ProjectionInput { projection: [...], nested_paths: [...] } instead of the previous projection: [...] form. This changes a user-visible/debuggable interface and breaks existing expectations (including the tests in this module), so tooling or assertions that parse/compare ScanRequest strings will regress even when only top-level projection indices are used.
Useful? React with 👍 / 👎.
1 participant
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
PR Checklist
Please convert it to a draft if some of the following conditions are not met.