Skip to content

fix: skip nan in prom remote write pipeline #6489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

fix: skip nan in prom remote write pipeline #6489

merged 1 commit into from
Jul 9, 2025

Conversation

shuiyisong
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Skip the NaN value in Prometheus remote write for pipeline execution.

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@shuiyisong
fix: skip nan in prom remote write pipeline
8695e17 
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
@shuiyisong shuiyisong requested review from paomian and evenyag July 9, 2025 09:54
@shuiyisong shuiyisong requested a review from a team as a code owner July 9, 2025 09:54
@github-actions github-actions bot added size/XS docs-not-required This change does not impact docs. labels Jul 9, 2025
evenyag
evenyag reviewed Jul 9, 2025
View reviewed changes
killme2008
killme2008 approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Jul 9, 2025
Merged via the queue into GreptimeTeam:main with commit d99cd98 Jul 9, 2025
77 of 79 checks passed
@shuiyisong shuiyisong added the backport This patch is to be backported to current release branch label Jul 10, 2025
@evenyag evenyag mentioned this pull request Jul 10, 2025
Closed
10 tasks
evenyag pushed a commit to evenyag/greptimedb that referenced this pull request Jul 10, 2025
@shuiyisong @evenyag
fix: skip nan in prom remote write pipeline (GreptimeTeam#6489)
37f32ba 
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
@evenyag evenyag mentioned this pull request Jul 10, 2025
Merged
5 tasks
evenyag pushed a commit that referenced this pull request Jul 10, 2025
@shuiyisong @evenyag
fix: skip nan in prom remote write pipeline (#6489)
8b2d1a3 
Signed-off-by: shuiyisong <xixing.sys@gmail.com>
Signed-off-by: evenyag <realevenyag@gmail.com>
@shuiyisong shuiyisong deleted the fix/remote_write_nan branch July 11, 2025 08:03
@evenyag evenyag removed the backport This patch is to be backported to current release branch label Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killme2008 killme2008 killme2008 approved these changes

@evenyag evenyag evenyag approved these changes

@paomian paomian Awaiting requested review from paomian

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuiyisong @killme2008 @evenyag