Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: replace timeout_millis and connect_timeout_millis with Duration in DatanodeClientOptions #4867

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Oct 23, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Updated DatanodeClientOptions to use Duration for timeout and connect_timeout with humantime_serde serialization.
Modified MetasrvBuilder to use the updated DatanodeClientOptions.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

@WenyXu WenyXu requested review from MichaelScofield and a team as code owners October 23, 2024 03:49
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.99%. Comparing base (6d503b0) to head (404a525).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4867      +/-   ##
==========================================
- Coverage   84.25%   83.99%   -0.27%     
==========================================
  Files        1129     1129              
  Lines      208474   208474              
==========================================
- Hits       175653   175101     -552     
- Misses      32821    33373     +552     

@waynexia waynexia changed the title fix: replace timeout_millis and connect_timeout_millis with Duration in DatanodeClientOptions fix!: replace timeout_millis and connect_timeout_millis with Duration in DatanodeClientOptions Oct 23, 2024
@github-actions github-actions bot added the breaking-change This pull request contains breaking changes. label Oct 23, 2024
@evenyag evenyag added this pull request to the merge queue Oct 23, 2024
Merged via the queue into GreptimeTeam:main with commit 5d42e63 Oct 23, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This pull request contains breaking changes. docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants