Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Release CI & make rustls use ring #4750

Merged
merged 23 commits into from
Sep 24, 2024
Merged

fix: Release CI & make rustls use ring #4750

merged 23 commits into from
Sep 24, 2024

Conversation

discord9
Copy link
Contributor

@discord9 discord9 commented Sep 20, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

use new dev-build image for release CI

Major changes are:

  • use new dev-build image built from newest Dockerfile
  • which install gcc-10 to avoid a compiler bug in gcc-9 warning by aws-lc-sys
  • update rustls to 0.23
  • use forked repo of tokio-rustls, hyper-rustls and rustls to set ring as default libcrypto and preventing building aws-lc-sys which have numerous building problem
  • and install cargo-binstall from binary to speed up building dev-build image(from 40 minutes to 20 mintues)

Checklist

  • wait for Release CI to pass on this branch
  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Sep 20, 2024
@discord9 discord9 marked this pull request as ready for review September 23, 2024 06:48
@discord9 discord9 requested a review from a team as a code owner September 23, 2024 06:48
@discord9 discord9 changed the title fix: Use new image(again) fix: Release CI & make rustls use ring Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (0f99218) to head (f50622d).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4750      +/-   ##
==========================================
- Coverage   84.56%   84.53%   -0.03%     
==========================================
  Files        1118     1117       -1     
  Lines      202889   202644     -245     
==========================================
- Hits       171566   171310     -256     
- Misses      31323    31334      +11     

docker/dev-builder/binstall/pull_binstall.sh Outdated Show resolved Hide resolved
docker/dev-builder/centos/Dockerfile Outdated Show resolved Hide resolved
docker/dev-builder/ubuntu/Dockerfile Outdated Show resolved Hide resolved
@waynexia waynexia added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 54f6e13 Sep 24, 2024
42 checks passed
@waynexia waynexia deleted the use_new_image branch September 24, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants