-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: build in asahi linux #4604
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4604 +/- ##
==========================================
- Coverage 84.93% 84.66% -0.27%
==========================================
Files 1096 1096
Lines 196699 196699
==========================================
- Hits 167060 166540 -520
- Misses 29639 30159 +520 |
@zyy17 could you confirm if this setting is still in use nowadays? I saw it's from early days. |
Although it's not being used now, I think we should keep this configuration. Maybe we need it in the future. |
What's the purpose of setting this linker? |
I guess it might be used when cross-compiling. |
It's possible used by Andorid platform where it is ARM arch. Please check if it's the case. For GCC linker on Asahi Linux, you should be able to install it manually. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
I recently had some problems compiling greptimedb on an asahi linux platform.
The error reported is as follows:
After investigation, found that linker was specified in cargo's configuration.
If not cross-compiling, it seems that we don't need to specify a linker.
Checklist