Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skip read-only region when trying to flush on region full #3966

Merged
merged 3 commits into from
May 16, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Read-only regions cannot be flushed. Skip them on trying to pick one when engine is full

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label May 16, 2024
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.07%. Comparing base (669a6d8) to head (14f182e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3966      +/-   ##
==========================================
- Coverage   85.38%   85.07%   -0.31%     
==========================================
  Files         978      978              
  Lines      168271   168279       +8     
==========================================
- Hits       143674   143167     -507     
- Misses      24597    25112     +515     

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
@evenyag evenyag added this pull request to the merge queue May 16, 2024
Merged via the queue into GreptimeTeam:main with commit 5c0a530 May 16, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants