-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement the CreateFlowProcedure
#3810
feat: implement the CreateFlowProcedure
#3810
Conversation
fdbc129
to
ecdb159
Compare
ecdb159
to
a590f26
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3810 +/- ##
==========================================
- Coverage 85.74% 85.33% -0.41%
==========================================
Files 951 954 +3
Lines 162837 163049 +212
==========================================
- Hits 139620 139139 -481
- Misses 23217 23910 +693 |
78b6626
to
0efe8ac
Compare
0efe8ac
to
7b663e5
Compare
CreateFlowTaskProcedure
CreateFlowProcedure
b88f1d1
to
df2fee1
Compare
df2fee1
to
4ee2b9f
Compare
2590213
to
e041c18
Compare
e041c18
to
f9c02f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost LGTM
Just lock the sink table name and we are good to go. |
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#3664
What's changed and what's your intention?
FlowMetadataManager
andFlowMetadataAllocator
toDdlContext
.CreateFlowProcedure
Tests will be added via another PR.
Checklist