-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement stdvar_over_time function #1291
feat: implement stdvar_over_time function #1291
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1291 +/- ##
===========================================
- Coverage 85.88% 85.49% -0.40%
===========================================
Files 500 501 +1
Lines 75756 75907 +151
===========================================
- Hits 65066 64895 -171
- Misses 10690 11012 +322 |
Sorry for the late reply. It looks very neat! The same as #1289 (comment):
Do you mind adding these two cases to your test as well? And you may also need the this function, let's wait a while before #1289 merged! |
@waynexia Thank for your reply. |
Hi, @waynexia |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thanks for this!
* feat: implement stdvar_over_time function * feat: add more test for stdvar_over_time * feat: add stdvar_over_time to functions.rs
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
I implement the
stdvar_over_time
function in PromQL and add necessary unit test.Checklist
Refer to a related PR or issue link (optional)
#1229