-
Notifications
You must be signed in to change notification settings - Fork 397
Open
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
@fengjiachun
just check the code and do the tests,
about copy parquet part for now its only support s3 and fs
greptimedb/src/common/datasource/src/object_store.rs
Lines 56 to 75 in 9860bca
pub fn build_backend(url: &str, connection: &HashMap<String, String>) -> Result<ObjectStore> { | |
let (schema, host, path) = parse_url(url)?; | |
let (root, _) = find_dir_and_filename(&path); | |
match schema.to_uppercase().as_str() { | |
S3_SCHEMA => { | |
let host = host.context(error::EmptyHostPathSnafu { | |
url: url.to_string(), | |
})?; | |
Ok(build_s3_backend(&host, &root, connection)?) | |
} | |
FS_SCHEMA => Ok(build_fs_backend(&root)?), | |
_ => error::UnsupportedBackendProtocolSnafu { | |
protocol: schema, | |
url, | |
} | |
.fail(), | |
} | |
} |
So I think just support s3 is OK and maybe support others in the future
Originally posted by @yihong0618 in #5585 (comment)
Currently, both copy from/to table/database
and external table
utilize build_backend
to create object storage, but only S3 is supported at this time. We need to extend support to other types of object storage.
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed