Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change EXPIRE WHEN to EXPIRE AFTER #170

Merged
merged 5 commits into from
May 27, 2024
Merged

feat: change EXPIRE WHEN to EXPIRE AFTER #170

merged 5 commits into from
May 27, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented May 21, 2024

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

Change expire_when to expire_after

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia merged commit 31dd060 into main May 27, 2024
6 checks passed
@waynexia waynexia deleted the expire-after branch May 27, 2024 06:40
@waynexia waynexia restored the expire-after branch May 27, 2024 06:48
@waynexia waynexia deleted the expire-after branch July 19, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants