-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add QueryContext to RegionRequestHeader #156
feat: add QueryContext to RegionRequestHeader #156
Conversation
2426058
to
6c609c9
Compare
Can you guys help to review when you have time? @killme2008 @MichaelScofield @WenyXu |
6c609c9
to
24c703b
Compare
@Kelvinyu1117 I'm ok with the proto change. But we need to change the GreptimeDB's codes first before merging this PR. |
Shouldn't the existing GreptimeDB point to the old revision? I guess I just need to change the revision to the latest commit of this repo in my branch of GreptimeDB in order to utilize this proto file? greptime-proto = { git = "https://github.com/GreptimeTeam/greptime-proto.git", rev = "2c14c6e22dfe957f40bb88dd01fb8530656de89b" } |
@Kelvinyu1117 If another person wants to make changes to proto, he would normally fork the main branch. If proto is merged too soon, he will see some compile errors not related to his codes. |
Understood, so should I change the URL to my fork in my GreptimeDB's branch at the moment? |
@Kelvinyu1117 yes |
24c703b
to
522cdc1
Compare
522cdc1
to
91f2a42
Compare
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This refers to the issue "Pass query context down to region server service in Datanode".
Checklist
Refer to a related PR or issue link (optional)
GreptimeTeam/greptimedb#3752