Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add shm notify proto #109

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

niebayes
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add a notify proto for the shared memory scheme.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niebayes niebayes requested a review from v0y4g3r October 16, 2023 12:37
Copy link
Contributor

@Nateiru Nateiru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niebayes niebayes changed the title feat: add shm notify proto [WIP] feat: add shm notify proto Oct 17, 2023
@Nateiru Nateiru self-requested a review October 18, 2023 02:44
@v0y4g3r v0y4g3r force-pushed the add_shm_notify_proto branch 3 times, most recently from fcb9d02 to d9315ee Compare October 18, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants