Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: concepts updates for v0.9 #1047

Merged
merged 14 commits into from
Jul 22, 2024
Merged

docs: concepts updates for v0.9 #1047

merged 14 commits into from
Jul 22, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Jul 8, 2024

What's Changed in this PR

Describe the change in this PR

Update concepts.

Checklist

  • Please confirm that all corresponding versions of the documents have been revised.
  • Please ensure that the content in summary.yml matches the current document structure when you changed the document structure.
  • This change requires follow-up update in localized docs.

Summary by CodeRabbit

  • Documentation
    • Updated architecture documentation to clarify roles and interactions of GreptimeDB components.
    • Enhanced data model documentation with detailed explanations of table columns and indexing.
    • Refined key concepts documentation to better describe database components and their functionalities.
    • Revised user guide overview to emphasize GreptimeDB's flexible architecture for metrics and event data.
    • Improved Chinese documentation with detailed descriptions of data models and key concepts.

@killme2008 killme2008 requested review from nicecui and a team as code owners July 8, 2024 23:13
Copy link
Contributor

coderabbitai bot commented Jul 8, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The updates to the GreptimeDB documentation include clarifications on architecture, data models, and key concepts. The changes refine descriptions of component roles, deployment requirements, and data handling processes, and introduce examples of Metric and Log tables. Additionally, new concepts like indexing methods and the "Flow" aggregation process are explained. The overall aim is to enhance user understanding and optimize query performance.

Changes

File Path Change Summary
docs/.../architecture.md Clarified the roles and interactions of Metasrv, Frontend, and Datanodes components, and updated deployment details.
docs/.../data-model.md (English & Chinese) Refined data model explanations, introduced Tag, Timestamp, and Field columns, and provided table examples.
docs/.../key-concepts.md (English & Chinese) Clarified database concepts, introduced "Flow" for continuous aggregation, and detailed indexing methods.
docs/.../overview.md (English & Chinese) Updated descriptions of GreptimeDB features like unified design for Metrics & Events and Cloud-Native architecture.

Poem

In the world of data vast and wide,
GreptimeDB stands with pride.
Metasrv, Frontend, Datanodes align,
Handling data, so fine.
Metrics and Logs, indexed with care,
Query performance, beyond compare.
With Flow's gentle, continuous stream,
GreptimeDB, the data dream. 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@killme2008 killme2008 marked this pull request as draft July 8, 2024 23:13
Copy link

cloudflare-workers-and-pages bot commented Jul 8, 2024

Deploying greptime-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 51df849
Status: ✅  Deploy successful!
Preview URL: https://6a9b1513.greptime-docs.pages.dev
Branch Preview URL: https://feature-update-concepts-v0-9.greptime-docs.pages.dev

View logs

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b26af97 and 6c65037.

Files selected for processing (4)
  • docs/nightly/en/user-guide/concepts/architecture.md (1 hunks)
  • docs/nightly/en/user-guide/concepts/data-model.md (2 hunks)
  • docs/nightly/en/user-guide/concepts/key-concepts.md (2 hunks)
  • docs/nightly/en/user-guide/concepts/overview.md (1 hunks)
Additional context used
LanguageTool
docs/nightly/en/user-guide/concepts/architecture.md

[grammar] ~11-~11: The word “setup” is a noun. The verb is spelled with a white space.
Context: ..., at least three nodes is required to setup a reliable Metasrv mini-cluster. _Met...

(NOUN_VERB_CONFUSION)


[uncategorized] ~13-~13: You might be missing the article “the” here.
Context: ... requests to. It also keeps monitoring availability and performance of _Datanode_s, to e...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~20-~20: You might be missing the article “the” here.
Context: ...verview.md) hold regions of tables in Greptime DB cluster. It accepts read and write r...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~25-~25: You might be missing the article “the” here.
Context: ...ure](/contributor-guide/overview.md) in contributor guide to learn more details about how c...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

docs/nightly/en/user-guide/concepts/key-concepts.md

[uncategorized] ~13-~13: Possible missing article found.
Context: ... Time-Series Table GreptimeDB designed time-series table to be the basic unit of da...

(AI_HYDRA_LEO_MISSING_THE)

docs/nightly/en/user-guide/concepts/data-model.md

[uncategorized] ~12-~12: You might be missing the article “the” here.
Context: ...at is commonly queried. The values in Tag columns are labels attached to the ...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...column is access_time. - remote_addr, http_status, http_method, `http_ref...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~87-~87: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...e Table model has a broad group of users and it's easy to learn, that we just introd...

(COMMA_COMPOUND_SENTENCE)


[typographical] ~87-~87: Usually, there’s no comma before “that”.
Context: ...ad group of users and it's easy to learn, that we just introduced the concept of time ...

(THAT_NO_COMMA)

Additional comments not posted (16)
docs/nightly/en/user-guide/concepts/architecture.md (4)

10-14: Approved: Improved grammar and clarity for Metasrv description.

The changes improve the readability and correctness of the documentation.

Tools
LanguageTool

[grammar] ~11-~11: The word “setup” is a noun. The verb is spelled with a white space.
Context: ..., at least three nodes is required to setup a reliable Metasrv mini-cluster. _Met...

(NOUN_VERB_CONFUSION)


[uncategorized] ~13-~13: You might be missing the article “the” here.
Context: ... requests to. It also keeps monitoring availability and performance of _Datanode_s, to e...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


16-18: Approved: Improved grammar and clarity for Frontend description.

The changes improve the readability and correctness of the documentation.


20-21: Approved: Improved grammar and clarity for Datanodes description.

The changes improve the readability and correctness of the documentation.

Tools
LanguageTool

[uncategorized] ~20-~20: You might be missing the article “the” here.
Context: ...verview.md) hold regions of tables in Greptime DB cluster. It accepts read and write r...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


23-25: Approved: Improved grammar and clarity for Standalone Mode and Developer Guide Reference.

The changes improve the readability and correctness of the documentation.

Tools
LanguageTool

[uncategorized] ~25-~25: You might be missing the article “the” here.
Context: ...ure](/contributor-guide/overview.md) in contributor guide to learn more details about how c...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)

docs/nightly/en/user-guide/concepts/overview.md (3)

3-3: Approved: Improved description of Why GreptimeDB.

The changes improve the readability and correctness of the documentation.


4-4: Approved: Improved description of Data Model.

The changes improve the readability and correctness of the documentation.


8-8: Approved: Improved description of Features that You Concern.

The changes improve the readability and correctness of the documentation.

docs/nightly/en/user-guide/concepts/key-concepts.md (5)

8-9: Approved: Improved description of Database.

The changes improve the readability and correctness of the documentation.


14-18: Approved: Improved description of Time-Series Table.

The changes improve the readability and correctness of the documentation.


40-42: Approved: Added description for Index.

The changes improve the readability and correctness of the documentation.


44-47: Approved: Added description for View.

The changes improve the readability and correctness of the documentation.


49-51: Approved: Added description for Flow.

The changes improve the readability and correctness of the documentation.

docs/nightly/en/user-guide/concepts/data-model.md (4)

6-25: Approved: Improved description of data model.

The changes improve the readability and correctness of the documentation.

Tools
LanguageTool

[uncategorized] ~12-~12: You might be missing the article “the” here.
Context: ...at is commonly queried. The values in Tag columns are labels attached to the ...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


Line range hint 27-60:
Approved: Added example and improved description of metric table.

The changes improve the readability and correctness of the documentation.

Tools
LanguageTool

[uncategorized] ~12-~12: You might be missing the article “the” here.
Context: ...at is commonly queried. The values in Tag columns are labels attached to the ...

(AI_EN_LECTOR_MISSING_DETERMINER_THE)


61-79: Approved: Added example and improved description of log table.

The changes improve the readability and correctness of the documentation.

Tools
LanguageTool

[uncategorized] ~78-~78: Loose punctuation mark.
Context: ...column is access_time. - remote_addr, http_status, http_method, `http_ref...

(UNLIKELY_OPENING_PUNCTUATION)


87-95: Approved: Improved description of design considerations.

The changes improve the readability and correctness of the documentation.

Tools
LanguageTool

[uncategorized] ~87-~87: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...e Table model has a broad group of users and it's easy to learn, that we just introd...

(COMMA_COMPOUND_SENTENCE)


[typographical] ~87-~87: Usually, there’s no comma before “that”.
Context: ...ad group of users and it's easy to learn, that we just introduced the concept of time ...

(THAT_NO_COMMA)

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ZH docs should be updated also?

@nicecui
Copy link
Collaborator

nicecui commented Jul 16, 2024

I'll add the zh docs right now

@nicecui nicecui marked this pull request as ready for review July 16, 2024 05:50
@killme2008
Copy link
Contributor Author

Please don't merge it, I'll modify it tomorrow if I feel better.

@nicecui nicecui marked this pull request as draft July 16, 2024 05:52
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6c65037 and ed7caff.

Files selected for processing (4)
  • docs/nightly/en/user-guide/concepts/key-concepts.md (2 hunks)
  • docs/nightly/zh/user-guide/concepts/data-model.md (2 hunks)
  • docs/nightly/zh/user-guide/concepts/key-concepts.md (2 hunks)
  • docs/nightly/zh/user-guide/concepts/overview.md (1 hunks)
Files skipped from review due to trivial changes (2)
  • docs/nightly/en/user-guide/concepts/key-concepts.md
  • docs/nightly/zh/user-guide/concepts/overview.md
Additional context used
LanguageTool
docs/nightly/zh/user-guide/concepts/data-model.md

[uncategorized] ~74-~74: 动词的修饰一般为‘形容词(副词)+地+动词’。您的意思是否是:巨大"地"优化
Context: ...们可以更好地管理数据兼容性。 - Schema 通过其类型、长度等信息带来了巨大的优化存储和计算的好处,我们可以进行有针对性的优化。 - 当我们有了表格 Sche...

(wb4)

Additional comments not posted (7)
docs/nightly/zh/user-guide/concepts/key-concepts.md (4)

7-8: Clarification and expansion on the concept of a database.

The updated definition and the addition of data isolation capabilities provide a clearer understanding of the database's role within GreptimeDB.


12-20: Detailed explanation of Time-Series Tables.

The addition of a detailed description of time-series tables, including the requirement for a TIME INDEX, enhances the understanding of how GreptimeDB handles time-series data.


34-37: Introduction of Index as a performance optimization method.

This section clearly explains the role of indexes in improving query performance, which is crucial for users to understand how to optimize their database usage.


44-46: Introduction of the 'Flow' concept.

The explanation of the 'Flow' concept as a continuous aggregation process is a valuable addition for users to understand advanced data processing capabilities in GreptimeDB.

docs/nightly/zh/user-guide/concepts/data-model.md (3)

9-12: Enhanced descriptions for Tag and Timestamp columns.

The detailed explanations for the Tag and Timestamp columns, including their indexing capabilities, provide a clearer understanding of their roles and performance implications in queries.


18-29: Introduction of the TIME INDEX declaration.

The explicit declaration of TIME INDEX for the timestamp column in the system_metrics table clarifies its importance in time-series data handling.


48-64: Introduction of full-text indexing for the request field in log tables.

The use of FULLTEXT indexing for the request field is a significant addition that will enhance the performance of text-based queries in log tables.

@killme2008 killme2008 force-pushed the feature/update-concepts-v0.9 branch from 1fa3fcb to acc44fd Compare July 22, 2024 01:58
@killme2008 killme2008 marked this pull request as ready for review July 22, 2024 02:05
@killme2008
Copy link
Contributor Author

@nicecui Already done. Please take a look. If everything is good, we can copy them into v0.9 folder too.

Copy link
Collaborator

@nicecui nicecui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add docs to v0.9

docs/nightly/en/user-guide/concepts/why-greptimedb.md Outdated Show resolved Hide resolved
docs/nightly/en/user-guide/concepts/why-greptimedb.md Outdated Show resolved Hide resolved
killme2008 and others added 3 commits July 21, 2024 20:06
Co-authored-by: Yiran <cuiyiran3@gmail.com>
Co-authored-by: Yiran <cuiyiran3@gmail.com>
@killme2008
Copy link
Contributor Author

LGTM, please add docs to v0.9

Done

@killme2008 killme2008 requested a review from nicecui July 22, 2024 03:18
@nicecui nicecui merged commit de3bcbd into main Jul 22, 2024
4 checks passed
@nicecui nicecui deleted the feature/update-concepts-v0.9 branch July 22, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants