Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates that #127 can indeed be solved by changing the name of the
thencombinator to something else. Here I purposefully chose the horrible namethenceforth(wiktionary 🙂) to indicate that a better name should be come up with.It's a bit difficult to demonstrate the fix because of the setup. Let me describe how I verified that it works:
Details
yarn && yarn build(might need to do it twice, but it will work)yarn && yarn vitestto see that the test passes and does not hang vitest indefinitelyTo reproduce the issue and see that the test hangs without the fix, do these steps:
yarn build(maybe twice)yarnfor good luck I guess (might not be needed, haven't tried)