Skip to content

Remove queue usage for level up dialogue fixes #699

9a670c2
Select commit
Loading
Failed to load commit list.
Merged

General bug fixes #701

Remove queue usage for level up dialogue fixes #699
9a670c2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 29, 2025 in 0s

35.20% (+0.00%) compared to 8323d21

View this Pull Request on Codecov

35.20% (+0.00%) compared to 8323d21

Details

Codecov Report

Attention: Patch coverage is 14.81481% with 23 lines in your changes missing coverage. Please review.

Project coverage is 35.20%. Comparing base (8323d21) to head (9a670c2).

Files with missing lines Patch % Lines
...in/content/entity/player/dialogue/type/LevelUp.kts 0.00% 12 Missing ⚠️
...lient/instruction/handle/FloorItemOptionHandler.kt 0.00% 1 Missing ⚠️
...uction/handle/InterfaceOnFloorItemOptionHandler.kt 0.00% 1 Missing ⚠️
.../instruction/handle/InterfaceOnNPCOptionHandler.kt 0.00% 1 Missing ⚠️
...struction/handle/InterfaceOnObjectOptionHandler.kt 0.00% 1 Missing ⚠️
...struction/handle/InterfaceOnPlayerOptionHandler.kt 0.00% 1 Missing ⚠️
...gine/client/instruction/handle/NPCOptionHandler.kt 0.00% 1 Missing ⚠️
...e/client/instruction/handle/ObjectOptionHandler.kt 0.00% 1 Missing ⚠️
...e/client/instruction/handle/PlayerOptionHandler.kt 0.00% 1 Missing ⚠️
...n/content/entity/player/dialogue/DialogueInput.kts 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
Files with missing lines Coverage Δ
...lin/content/entity/player/dialogue/type/LevelUp.kt 100.00% <100.00%> (ø)
...lient/instruction/handle/FloorItemOptionHandler.kt 0.00% <0.00%> (ø)
...uction/handle/InterfaceOnFloorItemOptionHandler.kt 0.00% <0.00%> (ø)
.../instruction/handle/InterfaceOnNPCOptionHandler.kt 0.00% <0.00%> (ø)
...struction/handle/InterfaceOnObjectOptionHandler.kt 0.00% <0.00%> (ø)
...struction/handle/InterfaceOnPlayerOptionHandler.kt 0.00% <0.00%> (ø)
...gine/client/instruction/handle/NPCOptionHandler.kt 0.00% <0.00%> (ø)
...e/client/instruction/handle/ObjectOptionHandler.kt 0.00% <0.00%> (ø)
...e/client/instruction/handle/PlayerOptionHandler.kt 0.00% <0.00%> (ø)
...n/content/entity/player/dialogue/DialogueInput.kts 44.73% <0.00%> (ø)
... and 3 more

... and 2 files with indirect coverage changes

@@            Coverage Diff            @@
##               main     #701   +/-   ##
=========================================
  Coverage     35.20%   35.20%           
- Complexity     5087     5090    +3     
=========================================
  Files          1397     1397           
  Lines         53536    53538    +2     
  Branches      10470    10469    -1     
=========================================
+ Hits          18845    18848    +3     
  Misses        31105    31105           
+ Partials       3586     3585    -1     
Components Coverage Δ
Content 31.30% <21.05%> (+0.01%) ⬆️
Engine 38.33% <0.00%> (-0.03%) ⬇️
Network 71.37% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.