Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented May 22, 2025

  • Add chartering ships Transport links #693
  • Add charter crew and stan npcs
  • Add charter areas
  • Add charter prices
  • Fix commands from crashing game loop

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 40.64516% with 92 lines in your changes missing coverage. Please review.

Project coverage is 35.26%. Comparing base (f61b53f) to head (6467421).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ain/kotlin/content/entity/obj/ship/CharterShip.kts 35.60% 65 Missing and 20 partials ⚠️
...client/instruction/handle/ExecuteCommandHandler.kt 0.00% 5 Missing ⚠️
...ain/kotlin/content/entity/obj/ship/CharterShips.kt 93.75% 0 Missing and 1 partial ⚠️
...tent/entity/player/command/admin/AdminCommands.kts 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
game/src/main/kotlin/GameModules.kt 79.16% <100.00%> (+0.90%) ⬆️
...ain/kotlin/content/entity/obj/ship/CharterShips.kt 93.75% <93.75%> (ø)
...tent/entity/player/command/admin/AdminCommands.kts 3.58% <0.00%> (-0.01%) ⬇️
...client/instruction/handle/ExecuteCommandHandler.kt 0.00% <0.00%> (ø)
...ain/kotlin/content/entity/obj/ship/CharterShip.kts 35.60% <35.60%> (ø)

... and 2 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #695      +/-   ##
============================================
+ Coverage     35.24%   35.26%   +0.01%     
- Complexity     5068     5084      +16     
============================================
  Files          1391     1393       +2     
  Lines         53257    53411     +154     
  Branches      10415    10454      +39     
============================================
+ Hits          18772    18836      +64     
- Misses        30921    30988      +67     
- Partials       3564     3587      +23     
Components Coverage Δ
Content 31.38% <42.00%> (+0.05%) ⬆️
Engine 38.36% <0.00%> (-0.02%) ⬇️
Network 71.37% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib merged commit 253f9db into main May 23, 2025
5 checks passed
@GregHib GregHib deleted the charter-ships branch May 23, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant