StringEntry/NameEntry fix #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… has last input recall for player name usage. Change ClanChatDecoder to StringEntryDecoder for new StringEntry which lets user input much longer strings
GregHib
approved these changes
May 16, 2025
GregHib
added a commit
that referenced
this pull request
May 23, 2025
* fixed chicken drops table now working * update chicken * fix some spawns in white wolf mountain and added missing and added some dialogues * added asgarnia ice dungeon spawns, gfx, anims, drops etc * Update Ice_Giant.kts * all dungeon stuff for brimhavern * Update Ice_Giant.kts * StringEntry/NameEntry fix (#685) * Change StringEntry to NameEntry, which has a max of 13 characters and has last input recall for player name usage. Change ClanChatDecoder to StringEntryDecoder for new StringEntry which lets user input much longer strings * Fix decoder test and decoder-packets.csv data to match * Add Prince Ali Rescue Quest (#687) * Add karamja and port sarim npcs * Add prince ali rescue npcs * Add hassan, osman, leela and ned dialogues * Add cat expressions * Add more quest dialogue * Improvements to DropTableConverter * More dialogues * Simplify quest journals by using quest definitions * Fix mill controls * Add picking object sounds * Add Ali Morrisane * Dialogue tweaks * Fix gate sounds * Add prison door * Add spinning wheel anims and sounds * Dialogue finishing touches * Quest complete & tollgate reward --------- Co-authored-by: jarryd229 <15334102+jarryd229@users.noreply.github.com> * Remove config naming magic (#689) * Make drop_table's explicit rather than use a mix of names and categories * Check drop tables exist on startup * Simplify anim configs with combat_anims * Make combat_sounds explicit * Increase gradle wrapper memory * Require combat anims to exist and check for at least some sounds * Remove unused categories and make sure the slayer categories are plural * Add missing spider sounds * Fix slayer tasks * Bump gradlew mem to 600mb * Set gradlew mem min 500mb * update npc n drops and remove what didnt need to be add * update the final parts for brimhaven dungeon * fixed baby dragons bones --------- Co-authored-by: LucidSoft <69691787+lucid-soft@users.noreply.github.com> Co-authored-by: Greg <GregHib@users.noreply.github.com> Co-authored-by: jarryd229 <15334102+jarryd229@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringEntry retrieves a string longer than 13 characters, while NameEntry only allows entries of up to 13 characters. ClanChatNameDecoder has been updated and renamed to it's proper function, removing an erroneous int read.