fix issues with creating Seuratv5 obj #2237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Seurat v5 had a regression in terms of the flexibility of objects that can be imported in. Specifically, colnames are rownames are constrained to only be type
character, with no smart conversions on their end as of now. As our dgEMatrix had typearrayfor colnames and rownames, a simple switch fixes this errant behaviour. An associated error message people received was (Error in slot(object = object, name = "features")[[layer]] <- features: more elements supplied than there are to replace)Fixes #2212, #2136, #2069, #2052, #1999, #2091, #2040
Tests
4.1,4.4. Regressions with creating Seurat objects are no longer failing.