Skip to content

Dev module score #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rcorces merged 6 commits into from
Nov 7, 2022
Merged

Dev module score #1666

rcorces merged 6 commits into from
Nov 7, 2022

Conversation

@rcorces
Copy link
Collaborator

@rcorces rcorces commented Oct 6, 2022

Addressing #1631

rcorces added 6 commits October 4, 2022 17:07
@rcorces
add logging
f525379
@rcorces
typo
03870cc
@rcorces
mod logging
565f3d9
@rcorces
remove +1
12849f3 
As far as I can tell, this + 1 makes it so that if you get a feature in the top bin (for ex. bin 25) this causes an off-by-one error that results in an NA. I think this is a bug
@rcorces
finalize logging updates
db97759
@rcorces
remove duplicate message
48e3d3c
@rcorces rcorces requested a review from jeffmgranja October 6, 2022 22:04
@rcorces
Copy link
Collaborator Author

rcorces commented Oct 6, 2022

This is really the only commit of consequence here - 12849f3
The rest are changes to logging.

I'm fairly certain that the + 1 here causes an off-by-one indexing error that leads to NA values in binx when trying to sample from the top-most or bottom-most bins.

@rcorces rcorces merged commit 89802ab into dev Nov 7, 2022
@rcorces rcorces deleted the dev_moduleScore branch November 7, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffmgranja jeffmgranja Awaiting requested review from jeffmgranja

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rcorces