Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Janitor #62

Merged
merged 10 commits into from
Nov 22, 2011
Merged

Janitor #62

merged 10 commits into from
Nov 22, 2011

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Nov 20, 2011

Again some janitorial tasks on the graylog2-server code base.

Should be cherry-pickable if necessary.

* Added unit tests for Tools#getUTCTimestamp() and Tools#getUTCTimestampWithMilliseconds()
* Refactored  Tools#getUTCTimestamp() and Tools#getUTCTimestampWithMilliseconds()
* Improved JavaDoc comments
* Close OutputStreams properly if exceptions are being thrown
* Use predefined constants for HTTP status codes instead of number literals
* Use log level "debug" for debugging messages
* Use Tools#getUTCTimestampWithMilliseconds(long) instead of reimplementing its behaviour
lennartkoopmann pushed a commit that referenced this pull request Nov 22, 2011
@lennartkoopmann lennartkoopmann merged commit 4d68700 into Graylog2:develop Nov 22, 2011
@lennartkoopmann
Copy link
Contributor

thanks!

joschi pushed a commit that referenced this pull request Feb 13, 2018
We don't use HMR at the moment, remove code blocking webpack from
refreshing the page when changes are made.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants