Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to render Wizard in horizontal #4853

Merged
merged 2 commits into from
Jun 20, 2018
Merged

Add option to render Wizard in horizontal #4853

merged 2 commits into from
Jun 20, 2018

Conversation

edmundoa
Copy link
Contributor

@edmundoa edmundoa commented Jun 20, 2018

Sometimes we want to provide a wizard having some extra width for rendering components, e.g. when rendering a wizard inside a modal. In these cases, it is good rendering our Wizard component in horizontal, allowing us to save some space. This PR adds support for that.

Vertical vs horizontal:
screen shot 2018-06-20 at 13 13 37

Additionally, I also added a change, making the content CSS class in the outer row of the Wizard component customisable, as we may not always want to draw a border around the wizard.

Edmundo Alvarez added 2 commits June 20, 2018 12:23
This is helpful when we want to save some width for rendering other
components.
@edmundoa edmundoa added this to the 3.0.0 milestone Jun 20, 2018
@bernd bernd self-assigned this Jun 20, 2018
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bernd bernd merged commit 515c802 into master Jun 20, 2018
@bernd bernd deleted the horizontal-wizard branch June 20, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants