Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load pipeline actions and stores through a provider #4830

Merged
merged 3 commits into from
Jun 11, 2018
Merged

Conversation

edmundoa
Copy link
Contributor

@edmundoa edmundoa commented Jun 8, 2018

Inject actions and stores from CombinedProvider, ensuring they are all singleton and behaving like other actions and stores.

Fixes #4829

Inject actions and stores from `CombinedProvider`, ensuring they are all
singleton and behaving like other actions and stores.

Fixes #4829
@edmundoa edmundoa added this to the 3.0.0 milestone Jun 8, 2018
Copy link
Member

@dennisoelkers dennisoelkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. Maybe you have some additional time to fix the linter hints in the affected files? A lot of them are probably fixable automatically.

@edmundoa
Copy link
Contributor Author

Done.

@dennisoelkers dennisoelkers merged commit 70af512 into master Jun 11, 2018
@dennisoelkers dennisoelkers deleted the issue-4829 branch June 11, 2018 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants