Maintaining saved search id across search execution. #4743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Before this change, the saved search id which was selected on the search page was reset after the next search execution. This prevented any updates to saved searches, as updating the query took effect only after the next search execution.
With this change, a selected saved search id is added as a hidden field to the search query form, so it is maintained across search executions. This allows the user to select a saved search, modify the query and update the saved search afterwards.
Fixes #2285.
Needs to be merged into
master
as well.How Has This Been Tested?
Manual testing.
Screenshots (if appropriate):
Types of changes
Checklist: