Link decorator fixes #4742
Merged
Link decorator fixes #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 19, 2018 17:26
The `in` operator is not available for all types, and can make the condition throw an error.
Fixing a linting error
Preparing for the changes to come
This will help us to check if a field was decorated without passing around functions.
Move logic decorating message to MessageTableEntry, and apply the same logic to the message details.
|
The linting errors are not related to the changes, so I'll leave them be to not add more noise in here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #4669, I realised that there were a couple of problems left:
LinkFieldDecoratorthrew an error, as we used theindecorator to see if we needed to render a link for them, but that operator is only available in objects. I fixed that condition in here, to ensure it works in other decorated fieldsLinkFieldDecoratorwere not decorated when being rendered in the message table, as the logic to decorate the field was in the message details. To fix this, I moved the logic up the component tree, and used the already existingrenderForDisplayfunction to render the field