Add support for int values in SearchQuery #4733
Conversation
Add new SearchQueryField.Type for int and adapt code to support them.
Using `SearchQueryOperators.REGEX` as default is fine for String types, but it forces users to type an operator on Date and Int types. This commit leaves `REGEX` as default for Strings, but uses `EQUALS` for Dates and Ints, so users can still find values if they only write the value.
| case DATE: | ||
| return new FieldValue(parseDate(pair.getLeft()), pair.getRight(), negate); | ||
| case STRING: | ||
| return new FieldValue(pair.getLeft(), pair.getRight(), negate); | ||
| case INT: | ||
| return new FieldValue(Integer.parseInt(pair.getLeft()), pair.getRight(), negate); |
There was a problem hiding this comment.
Can we also use a long instead of an int here? This would make it work with very large values as well.
If MongoDB works with both, we could just parse the value into a long and rename the data type to NUMBER to make it more generic.
There was a problem hiding this comment.
So far I only needed an int and I tried to only implement that. I can look into it, though.
Anyway, I think NUMBER is not really good even with long support, because then I would also expect the method to work with double, float, and maybe other number types in Java. Also makes parsing the number a bit more of a challenge 😄
There was a problem hiding this comment.
That didn't work when parsing a number as long and then trying to serialize it to a DTO that has an int field. Mongojack tries to serialize the long value as an int and it fails with:
java.lang.ClassCastException: java.lang.Long cannot be cast to java.lang.Integer
|
As we discussed offline, I added a |
This PR adds support for querying
intvalues inSearchQuery, and adapts the default search operator, so that users can still findintandDatevalues even if they don't specify an operator.With the changes, these are the default operators:
foo-> Behaves like before the changesstring_field:foo-> Behaves like before the changesint_field:0-> Uses anequalsoperator to find0inint_fielddate_field:2018-04-18T12:15:00Z-> Uses anequalsoperator to find2018-04-18T12:15:00Zindate_field