Change select behaviour in SelectPopover #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On a single select, clicking on a selected option will not clear the selected item - On a multiselect, clicking on a selected option will deselect it, while keeping the status of other selected items
mariussturm
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
SelectPopoveris used as a single-option select, clicking on a selected option will deselect it (aka toggle it's select status). That behaviour is not consistent with other selects we use, and also doesn't provide much value (since we already have an option to clear the selection).This PR changes that behaviour by treating a click on a selected option in the same way as a click in a not-selected option.
On multiselects, it is still possible to deselect a single selected option by clicking on it.