Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SelectPopover improvements #4697

Merged
merged 2 commits into from
Apr 3, 2018
Merged

SelectPopover improvements #4697

merged 2 commits into from
Apr 3, 2018

Conversation

edmundoa
Copy link
Contributor

@edmundoa edmundoa commented Apr 3, 2018

  • Fixes a bug in condition that updates the selected item when its prop changes
  • Adds a disabled prop, that controls whether items in the SelectPopover are clickable or not

@edmundoa edmundoa added this to the 3.0.0 milestone Apr 3, 2018
@edmundoa edmundoa requested a review from mariussturm April 3, 2018 15:13
mariussturm
mariussturm approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@mariussturm mariussturm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariussturm mariussturm merged commit 5d7e0eb into master Apr 3, 2018
@mariussturm mariussturm deleted the select-popover-improvements branch April 3, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariussturm mariussturm mariussturm approved these changes

Assignees

@mariussturm mariussturm

Labels
ready-for-review
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundoa @mariussturm