Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover improvements #4690

Merged
merged 4 commits into from
Mar 27, 2018
Merged

Popover improvements #4690

merged 4 commits into from
Mar 27, 2018

Conversation

edmundoa
Copy link
Contributor

This PR adds a couple of improvements to popovers, namely:

  • SelectPopover:

    • Let consumers control if the popover should disappear after an item has been selected
    • Let consumers customize clear selection text via a prop
    • Add support for multiple selected entries

  • ColorPickerPopover:

    • Let consumers control if the popover should disappear after an item has been selected

Edmundo Alvarez added 4 commits March 26, 2018 15:23
Pass callback to hide popover on select
c0afa34 
In this way, consumers of the SelectPopover can decide if the popover
should hide when an item is selected.
Pass callback to hide popover on select
dbc9491 
In this way, consumers of ColorPickerPopover can decide if the popover
should hide when an item is selected.
Allow to customize clear selection text
ce393ee
Allow multiple selections in SelectPopover
f08979c
@edmundoa edmundoa added this to the 3.0.0 milestone Mar 27, 2018
@edmundoa edmundoa requested a review from mariussturm March 27, 2018 12:52
mariussturm
mariussturm approved these changes Mar 27, 2018
View reviewed changes
Copy link
Contributor

@mariussturm mariussturm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariussturm mariussturm merged commit 2df062f into master Mar 27, 2018
@mariussturm mariussturm deleted the popover-improvements branch March 27, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariussturm mariussturm mariussturm approved these changes

Assignees

@mariussturm mariussturm

Labels
ready-for-review
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundoa @mariussturm