Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let user of DataTable control if table is responsive #4633

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

edmundoa
Copy link
Contributor

@edmundoa edmundoa commented Mar 2, 2018

Responsive tables may clip dropdowns or other elements that overflow the container vertically, so this may not be something we want to use everywhere. The useResponsiveTable prop let us disable the responsive styles if we display dropdowns inside the table, or if the table is not expected to be too wide.

More information on table-responsive:
https://getbootstrap.com/docs/3.3/css/#tables-responsive

Responsive tables may clip dropdowns or other elements that overflow the
container vertically, so this may not be something we want to use
everywhere. The `useResponsiveTable` prop let us disable the responsive
styles if we display dropdowns inside the table.

More information on `table-responsive`:
https://getbootstrap.com/docs/3.3/css/#tables-responsive
@edmundoa edmundoa added this to the 3.0.0 milestone Mar 2, 2018
Copy link
Contributor

@mariussturm mariussturm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariussturm mariussturm merged commit 8d19af2 into master Mar 2, 2018
@mariussturm mariussturm deleted the data-table-responsive-prop branch March 2, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants